Skip to content

Conversation

@qpdpQ
Copy link
Contributor

@qpdpQ qpdpQ commented Jun 5, 2023

for ticket: https://github.ibm.com/IBMPrivateCloud/roadmap/issues/58807
An easier way to all multiple operandBindInfos mounting same secret
When two operandBindInfos are watching same secret/configmap, they are adding the same label to the secret/configmap operator.ibm.com/watched-by-opbi-with-name: ibm-licensing-bindinfo
This pr will try to fix it by adding a number after the label key

test:

  1. install cs-operator and odlm
  2. create two operandBindInfos for Licensing configmaps and secrets

expect result:

  1. operandBindInfo will not fail
  2. configmaps and secrets will be copied to another namespace
  3. there will be a new label in the secret <namespace>.<name>/bindinfo: true

This image can be used to verify quay.io/yuchen_li1/odlm-amd64@sha256:ba111b9726675779bbdaafd6bfcbf583d6049d609686b70b3e4b43c0c285fcaa

test looks good to me:

labels:
    ibm-common-services.ibm-iam-test-bindinfo/bindinfo: 'true'
    ibm-common-services.ibm-iam-bindinfo/bindinfo: 'true'
    operator.ibm.com/managedBy-opbi: original

Signed-off-by: Allen Li <[email protected]>
@ibm-ci-bot
Copy link
Contributor

@qpdpQ: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kind-e2e-test-operand-deployment-lifecycle-manager-amd64 bf70411 link true /test e2e-test-kind-operand-deployment-lifecycle-manager-amd64

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Daniel-Fan
Copy link
Contributor

Thank you @qpdpQ !
It looks good to me!

I believe that this would be a good enhancement for Bedrock v4.1 as well.
Would you mind opening an enterprise Github issue to track this enhancement for Bedrock v4.1?

Also could you help to open an issue to track the E2E Test update on kind cluster for LTSR branch as well?
We could follow this PR to update the test case. #927
We could try git cherry-pick to pick up the test case changes. But some of the details would be different since there are some new enhancement in ODLM v4.0.

Copy link
Contributor

@Daniel-Fan Daniel-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ibm-ci-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Daniel-Fan, qpdpQ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibm-ci-bot ibm-ci-bot added the lgtm label Jun 6, 2023
@Daniel-Fan Daniel-Fan merged commit 3fc524f into IBM:release-ltsr Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants