Skip to content

handle operator namespace could be optional in OperandRegistry #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibm-ci-bot merged 2 commits into from
Aug 25, 2023
Merged

handle operator namespace could be optional in OperandRegistry #963

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe3794d
fix odlm permission issue due to missing opt ns
Aug 24, 2023
7480893
notfound error condition added
Aug 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix odlm permission issue due to missing opt ns 
Signed-off-by: YuChen <[email protected]>
  • Loading branch information
YuChen committed Aug 24, 2023
commit fe3794d2249c82798836c3c513aa67dba891161a
2 changes: 1 addition & 1 deletion controllers/operator/manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ func (m *ODLMOperator) GetOperandRegistry(ctx context.Context, key types.Namespa
reg.Spec.Operators[i].Namespace = key.Namespace
}
if o.SourceName == "" || o.SourceNamespace == "" {
catalogSourceName, catalogSourceNs, err := m.GetCatalogSourceFromPackage(ctx, o.PackageName, o.Namespace, o.Channel, key.Namespace, excludedCatalogSources)
catalogSourceName, catalogSourceNs, err := m.GetCatalogSourceFromPackage(ctx, o.PackageName, reg.Spec.Operators[i].Namespace, o.Channel, key.Namespace, excludedCatalogSources)
if err != nil {
return nil, err
}
Expand Down