Skip to content

Add support for sharing Service data via ConfigMap with OperandBindInfo #993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ibm-ci-bot merged 5 commits into from
Nov 3, 2023
Merged

Add support for sharing Service data via ConfigMap with OperandBindInfo #993

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82f8ac1
added new type ServiceData as a Bindable
bitscuit Nov 3, 2023
5aa8c10
added Service data copying to OperandBindInfo
bitscuit Nov 3, 2023
c4b197b
fixed incorrect comment referring to Route when copying Service
bitscuit Nov 3, 2023
dc2b8eb
added missing error handling when executing jsonpath parsing
bitscuit Nov 3, 2023
07a957c
fixed sanitized service data value concatenating across multiple keys…
bitscuit Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixed incorrect comment referring to Route when copying Service 
Signed-off-by: Henry H Li <[email protected]>
  • Loading branch information
@bitscuit
bitscuit committed Nov 3, 2023
commit c4b197b8d131a1943d50812cb728c100ce2845a0
2 changes: 1 addition & 1 deletion controllers/operandbindinfo/operandbindinfo_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ func (r *Reconciler) Reconcile(ctx context.Context, req ctrl.Request) (_ ctrl.Re
requeue = requeue || requeueRoute
}
}
// Copy Route data into configmap and share configmap
// Copy Service data into configmap and share configmap
if binding.Service != nil {
requeueService, err := r.copyService(ctx, *binding.Service, "", operandNamespace, bindRequest.Namespace, key, bindInfoInstance, requestInstance)
if err != nil {
Expand Down