bug: Invalid enum members modifiers

[Egor18]

Hi. I found out that Spoon is probably wrong about the 'final' and 'public' modifiers of enum members.
Consider the following code:

public enum MyEnum {
    ONE,
    TWO,
    THREE;

    private static int len = -1; // Spoon says that len is final and public, but it is not!

    public static void f() {
        len = 44;
    }
}

BTW, If I do the same in a class it works fine:

public class MyClass {

    private static int len = -1; // len is not final and is not public (as expected)

    public static void f() {
        len = 44;
    }
}

This PR contains failing test cases (see lenField.isFinal() and lenField.isPublic()).
Any ideas how to fix this?
Thanks.

[tdurieux]

It seems to be related to this, I will double check:

spoon/src/main/java/spoon/support/compiler/jdt/JDTTreeBuilder.java

Lines 1143 to 1149 in c5cc06e

	if (fieldDeclaration.binding.declaringClass != null && fieldDeclaration.binding.declaringClass.isEnum()) {
	//enum values take over visibility from enum type
	//JDT compiler has a bug that enum values are always public static final, even for private enum
	field.setExtendedModifiers(getModifiers(fieldDeclaration.binding.declaringClass.modifiers, true, false));
	} else {
	field.setExtendedModifiers(getModifiers(fieldDeclaration.binding.modifiers, true, false));
	}

[monperrus]

LGTM. Ready for merge?

[Egor18]

Yes, I hope this fix helps.

[pvojtechovsky]

Thank You Egor ;-)