Skip to content

refactor: use static import for asserts in tests #2655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pvojtechovsky merged 13 commits into from
Oct 17, 2018
Merged

refactor: use static import for asserts in tests #2655

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
8ecc877
refactor: use static import for assert
zielint0 Oct 11, 2018
102c8a5
refactor: use static import for assert
zielint0 Oct 11, 2018
bc0c8eb
refactor: use static import for assert
zielint0 Oct 11, 2018
89d750d
refactor: use static import for assert
zielint0 Oct 11, 2018
eda7304
refactor: use static import for assert
zielint0 Oct 11, 2018
21119e2
refactor: use static import for assert
zielint0 Oct 11, 2018
5ff0e5a
refactor: use static import for assert
zielint0 Oct 11, 2018
a887a26
refactor: use static import for assert
zielint0 Oct 11, 2018
0607139
refactor: use static import for assert
zielint0 Oct 11, 2018
b94dd0e
refactor: use static import for assert
zielint0 Oct 11, 2018
db2dba0
refactor: use static import for assert
zielint0 Oct 11, 2018
19d007e
refactor: use static import for assert
zielint0 Oct 11, 2018
2722c6e
refactor: use static import for assert
zielint0 Oct 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: use static import for assert
  • Loading branch information
@zielint0
zielint0 committed Oct 11, 2018
commit 21119e249cbf5b1b276080b343fb6c37476028f1
15 changes: 7 additions & 8 deletions src/test/java/spoon/test/api/MetamodelTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
*/
package spoon.test.api;

import org.junit.Assert;
import org.junit.Test;
import spoon.Launcher;
import spoon.SpoonAPI;
Expand Down Expand Up @@ -664,26 +663,26 @@ public void listValueRoleSetOn() {
assertEquals(1, typeMembers.size());
assertEquals(1, ctClass.getTypeMembers().size());
assertSame(ctClass, field1.getDeclaringType());
Assert.assertThat(Arrays.asList("field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList("field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
//contract: call of add on RoleHandler collection adds the item into real collection too
typeMembers.add(field2);
assertSame(ctClass, field2.getDeclaringType());
Assert.assertThat(Arrays.asList("field1", "field2"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList("field1", "field2"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
//contract: call of set on RoleHandler collection replaces the item in real collection
typeMembers.set(0, field3);
assertSame(ctClass, field3.getDeclaringType());
Assert.assertThat(Arrays.asList("field3", "field2"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList("field3", "field2"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
typeMembers.set(1, field1);
Assert.assertThat(Arrays.asList("field3", "field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList("field3", "field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
//contract: call of remove(int) on RoleHandler collection removes the item in real collection
assertSame(field3, typeMembers.remove(0));
Assert.assertThat(Arrays.asList("field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList("field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
//contract: call of remove(Object) which does not exist does nothing
assertFalse(typeMembers.remove(field2));
Assert.assertThat(Arrays.asList("field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList("field1"), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
//contract: call of remove(Object) on RoleHandler collection removes the item in real collection
assertTrue(typeMembers.remove(field1));
Assert.assertThat(Arrays.asList(), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
assertThat(Arrays.asList(), is(ctClass.filterChildren(new TypeFilter(CtField.class)).map((CtField e) -> e.getSimpleName()).list()));
}

@Test
Expand Down