refactor: flip order of comparison - put literal first to lower risk of NPE#2674
Merged
monperrus merged 3 commits intoINRIA:masterfrom Oct 16, 2018
zielint0:refactor-flip-order-of-comparison-put-literal-first
Merged
refactor: flip order of comparison - put literal first to lower risk of NPE#2674monperrus merged 3 commits intoINRIA:masterfrom zielint0:refactor-flip-order-of-comparison-put-literal-first
monperrus merged 3 commits intoINRIA:masterfrom
zielint0:refactor-flip-order-of-comparison-put-literal-first
Conversation
Collaborator
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code inspection
Reports calls to .equals() whose arguments are String literals. Some coding standards specify that String literals should be the target of .equals(), rather than argument, thus minimizing NullPointerExceptions.