Skip to content

Fix/type error filter mount requested backport #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tanyaka wants to merge 2 commits into
base: ionos-dev
Choose a base branch
from
Open

Fix/type error filter mount requested backport #175

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
15ec492
fix(files): Ensure the filter instance is mounted
susnux Feb 20, 2025
d9af064
refactor: use eventbus for updated filters
susnux Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix(files): Ensure the filter instance is mounted 
`reset` could be called before the filters are mounted,
in this case it is valid to update the presets, but we must not try to
access the vue instance (as it does not exist yet).

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux @tanyaka
susnux authored and tanyaka committed May 21, 2025
commit 15ec49262cc03813fb82fb64577de054a7fdc181
2 changes: 1 addition & 1 deletion apps/files/src/filters/HiddenFilesFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class HiddenFilesFilter extends FileListFilter {

constructor() {
super('files:hidden', 0)
this.showHidden = loadState<UserConfig>('files', 'config', { show_hidden: false }).show_hidden
this.showHidden = loadState<Partial<UserConfig>>('files', 'config', { show_hidden: false }).show_hidden

subscribe('files:config:updated', ({ key, value }) => {
if (key === 'show_hidden') {
Expand Down
7 changes: 6 additions & 1 deletion apps/files/src/filters/TypeFilter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,12 @@ class TypeFilter extends FileListFilter {

public setPresets(presets?: ITypePreset[]) {
this.currentPresets = presets ?? []
this.currentInstance!.$props.presets = presets
if (this.currentInstance !== undefined) {
// could be called before the instance was created
// (meaning the files list is not mounted yet)
this.currentInstance.$props.presets = presets
}

this.filterUpdated()

const chips: IFileListFilterChip[] = []
Expand Down