Skip to content

IONOS(search): Fix SearchComposer.php filtering logic #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
printminion-co merged 7 commits into from
Aug 11, 2025
Merged

IONOS(search): Fix SearchComposer.php filtering logic #198

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
865041d
fix(search): Fix SearchComposer.php filtering logic
printminion-co Jul 28, 2025
a01ef03
test(SearchComposerTest): add unit tests for SearchComposer
printminion-co Jul 29, 2025
c7aa401
test(SearchComposerTest): add test for handling unknown search provider
printminion-co Jul 29, 2025
d6e8418
test(SearchComposerTest): add unit test for getProviders with multipl…
printminion-co Jul 29, 2025
db24557
test(SearchComposerTest): add test for provider icon generation
printminion-co Jul 30, 2025
e099c30
test(SearchComposerTest): add unit tests for getProviders with allowe…
printminion-co Jul 29, 2025
44d0d95
test(SearchComposerTest): add unit test for getProviders with mixed o…
printminion-co Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test(SearchComposerTest): add test for handling unknown search provider 
Signed-off-by: Misha M.-Kupriyanov <[email protected]>
  • Loading branch information
@printminion-co
printminion-co committed Aug 11, 2025
commit c7aa401935d9fcb21cfee2d005473a009f4bd6f8
15 changes: 15 additions & 0 deletions tests/lib/Search/SearchComposerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,13 @@

namespace Test\Search;

use InvalidArgumentException;
use OC\AppFramework\Bootstrap\Coordinator;
use OC\Search\SearchComposer;
use OCP\IAppConfig;
use OCP\IURLGenerator;
use OCP\IUser;
use OCP\Search\ISearchQuery;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Container\ContainerInterface;
use Psr\Log\LoggerInterface;
Expand Down Expand Up @@ -58,4 +61,16 @@ public function testGetProvidersWithNoRegisteredProviders(): void {
$this->assertIsArray($providers);
$this->assertEmpty($providers);
}

public function testSearchWithUnknownProvider(): void {
$this->setupEmptyRegistrationContext();

$user = $this->createMock(IUser::class);
$query = $this->createMock(ISearchQuery::class);

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage('Provider unknown_provider is unknown');

$this->searchComposer->search($user, 'unknown_provider', $query);
}
}