Skip to content

Marshaling #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pizza-planet merged 9 commits into from
Feb 28, 2018
Merged

Marshaling #10

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8bab6f4
Create CODE_OF_CONDUCT.md
Jan 29, 2018
67fbae3
Added support for marshaling to memory storage adapters
tstone Feb 26, 2018
3ce186a
Extracted marshal/unmarshal to be generic
tstone Feb 26, 2018
a21f5b3
Updated dalli storage adapter with marshaling
tstone Feb 26, 2018
526fc5e
coc
tstone Feb 26, 2018
7c7e570
consistency
tstone Feb 26, 2018
7f03298
raw -> marshaled
tstone Feb 26, 2018
1cea773
Standardized options to be ={} instead of =nil. Passing in nil for o…
tstone Feb 26, 2018
3cab0e6
Dropped serialization from dalli storage adapter
tstone Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Dropped serialization from dalli storage adapter
  • Loading branch information
@tstone
tstone committed Feb 27, 2018
commit 3cab0e64b6b03e239e60cf7ddcda6b19ef3b8507
6 changes: 2 additions & 4 deletions lib/atomic_cache/storage/dalli.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,11 @@ def add(key, new_value, ttl, user_options={})
end

def read(key, user_options={})
raw = @dalli_client.read(key, user_options)
unmarshal(raw, user_options)
@dalli_client.read(key, user_options)
end

def set(key, value, user_options={})
marshaled = marshal(value, user_options)
@dalli_client.set(key, marshaled, user_options)
@dalli_client.set(key, value, user_options)
end

end
Expand Down
5 changes: 2 additions & 3 deletions spec/atomic_cache/storage/dalli_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,12 @@ def delete(key, user_options); end
subject { AtomicCache::Storage::Dalli.new(dalli_client) }

it 'delegates #set without options' do
raw = Marshal.dump('value')
expect(dalli_client).to receive(:set).with('key', raw, {})
expect(dalli_client).to receive(:set).with('key', 'value', {})
subject.set('key', 'value')
end

it 'delegates #read without options' do
expect(dalli_client).to receive(:read).with('key', {}).and_return(Marshal.dump('asdf'))
expect(dalli_client).to receive(:read).with('key', {}).and_return('asdf')
subject.read('key')
end

Expand Down