Skip to content

Bug: Properly interface with Dalli client#19

Merged
lebeerman merged 3 commits intomainfrom
dalli-client-fix
Jun 23, 2021
Merged

Bug: Properly interface with Dalli client#19
lebeerman merged 3 commits intomainfrom
dalli-client-fix

Conversation

@tstone
Copy link
Collaborator

@tstone tstone commented Jun 23, 2021

Background

The Dalli storage adapter appears to incorrectly assume the adapter is Rails.cache instead of the actual Dalli client. This PR changes it to expect the Dalli client.

Tasks

  • Code of Conduct reviewed
  • Specs written and passing
  • Backwards-incompatible changes called out in this PR
  • Increment the version file (./lib/atomic_cache/version.rb) when applicable

@tstone tstone added the bug Something isn't working label Jun 23, 2021
@tstone tstone marked this pull request as ready for review June 23, 2021 15:57
Copy link
Contributor

@lebeerman lebeerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Only additional though around if atomic_cache should expect a default ttl when using a Dalli client when the :expires_in option is used on init. Guess this is more specific than the gem needs to be? (e: per DM - 👍 Dalli owns the default value behavior)

@lebeerman lebeerman merged commit 8fd699c into main Jun 23, 2021
@tstone tstone deleted the dalli-client-fix branch June 23, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants