Upgrade to pysaml 4.5 #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Tests are passing in all environments except for Python3.3, which fails with this error message: Since Python 3.3 is past end-of-life, maybe you just want to drop it from the support matrix? Let me know if you'd like me to investigate further... |
Collaborator
|
Great job @vkurup, thanks for your contribution! |
|
I also want to send a thanks @vkurup. I spent over two hours trying to get this solved and came up empty. Very much appreciate this PR. |
Contributor
Author
|
My pleasure, and thanks for the great package! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
want_response_signednow defaults to True instead of False, so we have to explicitly set it toFalsefor our tests.git bisectall the changes in the pysaml release to figure it out. It only breaks python3 because defusedxml monkey patches ElementTree on Python3. djangosaml2 tries to globally set the namespace values by setting them directly on ElementTree, but that object is no longer used. I changed it to more directly set the namespaces using the pysaml API.With these changes, all unit tests pass on all python and django versions.
