Skip to content

Fix to handle a case that causes error 500 when doing IdP initiated login #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knaperek merged 2 commits into from
Jun 11, 2016
Merged

Fix to handle a case that causes error 500 when doing IdP initiated login #15

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89d21f0
handled a case to avoid error 500 when doing IdP initiated login
ganiserb Jun 9, 2016
993ea5f
better wording
ganiserb Jun 9, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
handled a case to avoid error 500 when doing IdP initiated login
  • Loading branch information
@ganiserb
ganiserb committed Jun 9, 2016
commit 89d21f0487bacb2e91fffd59b85886fa17484dc2
12 changes: 9 additions & 3 deletions djangosaml2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ def csrf_exempt(view_func):
from saml2.client import Saml2Client
from saml2.metadata import entity_descriptor
from saml2.ident import code, decode
from saml2.sigver import MissingKey

from djangosaml2.cache import IdentityCache, OutstandingQueriesCache
from djangosaml2.cache import StateCache
Expand Down Expand Up @@ -209,9 +210,14 @@ def assertion_consumer_service(request,
oq_cache = OutstandingQueriesCache(request.session)
outstanding_queries = oq_cache.outstanding_queries()

# process the authentication response
response = client.parse_authn_request_response(xmlstr, BINDING_HTTP_POST,
outstanding_queries)
try:
response = client.parse_authn_request_response(xmlstr, BINDING_HTTP_POST,
outstanding_queries)
except MissingKey:
logger.error('MissingKey error in ACS')
return HttpResponseForbidden(
"The Identity Provider is not configured correctly: "
"certificate key missing")
if response is None:
logger.error('SAML response is None')
return HttpResponseBadRequest(
Expand Down