Python3 compatible dependencies #16
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
We actually have some unresolved issues with pysaml2 compatibility, so I prefer sticking with the exact version which is currently considered the best. |
"""We actually have some unresolved issues with pysaml2 compatibility, so I prefer sticking with the exact version which is currently considered the best.""" --Jozef
| install_requires=[ | ||
| 'pysaml2==4.0.5', | ||
| 'python-memcached==1.48', | ||
| 'python-memcached>=1.48', |
Collaborator
There was a problem hiding this comment.
I'd actually prefer to limit it to versions less than 2 at the same time. Also, could you please check that it really works with all newer versions released so far? Thanks.
Contributor
|
linsomniac/python-memcached#95 Perhaps |
Collaborator
|
Closing this since it turned out we don't need this dependency after all (see PR #20). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of binding exact versions (which are not py3 compatible) specify them as minimum versions so later (py3 compatible) ones can be installed.