restore #30 "if user attribute is callable then call it..." #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Would mind adding a test to make sure this doesn't happen again in the future? Thanks. |
Contributor
Author
|
sure. |
Add `process_first_name` to test model
|
Any change of this being merged? |
Collaborator
|
Thanks and sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes made in https://github.com/knaperek/djangosaml2/pull/30/files seem to have been overridden 73b6a45#diff-2cd834de0333b1e660410e18cca31448L210 so the
process_groupsexample no longer appears to work.This restores the
callablechange