Skip to content

Don't parse html with xml parser #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liquidpele wants to merge 5 commits into from
Closed

Don't parse html with xml parser #53

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b60149c
Don't parse html with xml parser, and instead get the data we need di…
Apr 11, 2017
d732a3b
Don't use the private method
Apr 11, 2017
43d182e
Remove un-used import, utilize the default option of getattr
Apr 11, 2017
501095a
Merge in my other PR about failing back to supported idp bindings, an…
Apr 12, 2017
2868b31
Somehow deleted the get_location method?
Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove un-used import, utilize the default option of getattr
  • Loading branch information
Reece authored and Reece committed Apr 11, 2017
commit 43d182efffe4f66df459665e203ea9bdccb863be
6 changes: 1 addition & 5 deletions djangosaml2/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,11 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from defusedxml import ElementTree
from django.conf import settings


def get_custom_setting(name, default=None):
if hasattr(settings, name):
return getattr(settings, name)
else:
return default
return getattr(settings, name, default)


def available_idps(config, langpref=None):
Expand Down