Skip to content

Don't parse html with xml parser #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knaperek merged 7 commits into from
Apr 13, 2017
Merged

Don't parse html with xml parser #54

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b60149c
Don't parse html with xml parser, and instead get the data we need di…
Apr 11, 2017
d732a3b
Don't use the private method
Apr 11, 2017
43d182e
Remove un-used import, utilize the default option of getattr
Apr 11, 2017
7e9ac0c
Reset the branch to not include the other PR
Apr 12, 2017
e47b2c4
fix copy/paste error
Apr 12, 2017
a49e2cc
Properly sign the http-redirect binding url, pysaml isn't clear about…
Apr 12, 2017
b6a428c
Remove big warning, signing http-redirect works now. Only sign if se…
Apr 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Properly sign the http-redirect binding url, pysaml isn't clear about… 
… this but it does work this way.
  • Loading branch information
Reece authored and Reece committed Apr 12, 2017
commit a49e2cc3526f62b926154eab689768e85370f505
9 changes: 5 additions & 4 deletions djangosaml2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ def csrf_exempt(view_func):
from saml2.ident import code, decode
from saml2.sigver import MissingKey
from saml2.response import StatusError
from saml2.xmldsig import SIG_RSA_SHA1 # support for this is required by spec

from djangosaml2.cache import IdentityCache, OutstandingQueriesCache
from djangosaml2.cache import StateCache
Expand Down Expand Up @@ -158,15 +159,15 @@ def login(request,

client = Saml2Client(conf)
http_response = None

logger.debug('Redirecting user to the IdP via %s binding.', binding)
if binding == BINDING_HTTP_REDIRECT:
try:
# we use sign kwarg to override in case of redirect binding
# otherwise pysaml2 may sign the xml for redirect which is incorrect
# do not sign the xml itself, instead us the sigalg to
# generate the signature as a URL param
session_id, result = client.prepare_for_authenticate(
entityid=selected_idp, relay_state=came_from,
binding=binding, sign=False)
binding=binding, sign=False, sigalg=SIG_RSA_SHA1)
except TypeError as e:
logger.error('Unable to know which IdP to use')
return HttpResponse(text_type(e))
Expand Down