Skip to content

Adding support for SHA256 signing #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knaperek merged 4 commits into from
Aug 8, 2017
Merged

Adding support for SHA256 signing #66

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
441b8d1
Adding support for SHA255 signing
WebSpider Jul 20, 2017
c5a74c7
making previous default still work
WebSpider Jul 20, 2017
dfb0f1d
Refactor and clean up logic from PR #66
knaperek Aug 8, 2017
ce04e77
Fix typos
knaperek Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adding support for SHA255 signing
  • Loading branch information
@WebSpider
WebSpider committed Jul 20, 2017
commit 441b8d163fc112251784f467231588b5a3eded7a
8 changes: 5 additions & 3 deletions djangosaml2/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ def csrf_exempt(view_func):
from saml2.sigver import MissingKey
from saml2.s_utils import UnsupportedBinding
from saml2.response import StatusError
from saml2.xmldsig import SIG_RSA_SHA1 # support for this is required by spec
from saml2.xmldsig import SIG_RSA_SHA1, SIG_RSA_SHA256 # support for SHA1 is required by spec

from djangosaml2.cache import IdentityCache, OutstandingQueriesCache
from djangosaml2.cache import StateCache
Expand Down Expand Up @@ -168,9 +168,11 @@ def login(request,
logger.debug('Redirecting user to the IdP via %s binding.', binding)
if binding == BINDING_HTTP_REDIRECT:
try:
# do not sign the xml itself, instead us the sigalg to
# do not sign the xml itself, instead use the sigalg to
# generate the signature as a URL param
sigalg = SIG_RSA_SHA1 if sign_requests else None
sig_alg = getattr(conf, '_sp_authn_requests_signed_alg', False)
sigalg = SIG_RSA_SHA1 if sign_requests and sig_alg == 'sha1' else None
sigalg = SIG_RSA_SHA256 if sign_requests and sig_alg == 'sha256' else None
session_id, result = client.prepare_for_authenticate(
entityid=selected_idp, relay_state=came_from,
binding=binding, sign=False, sigalg=sigalg)
Expand Down