Added condition to prevent crash when _sp_authn_requests_signed isn't set

[MiguelSR]

No description provided.

[knaperek]

Thanks. But wouldn't a oneliner like this

binding = BINDING_HTTP_POST if getattr(conf, '_sp_authn_requests_signed', False) else BINDING_HTTP_REDIRECT

be more DRY and Pythonic?

[MiguelSR]

I agree with getattr over hasattr, thanks!

I'd prefer a nested if over a one-liner in this case, as I try to keep my lines under 80 to fit PEP8. Anyway since this file has other lines with this style I have no problem of re-writing it as you said.

I'll commit right now.

[knaperek]

This 80-chars per line is actually the only PEP8 rule that is officially not respected by Django guidelines, and also by most of other serious projects. The reasoning is quite obvious - this rule comes from the previous century and sounds ridiculous in today's era of huge and wide screens. From what I have observed, 120 columns seems to be more preferred these days, even though there is not a strict limit.

Now, back to the topic :-) Thank for the new commit, and if I can bother you just a bit more - would you mind squashing those two commits into one? Thanks :-)

[MiguelSR]

Alright! I've squashed them into a single commit, hope everything's fine.

Thanks,
Miguel.

[knaperek]

Thank you!