Skip to content

Improve generator perf #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
viceroypenguin merged 1 commit into from
Jan 18, 2025
Merged

Improve generator perf #178

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 19 additions & 10 deletions src/Immediate.Handlers.Generators/ImmediateHandlersGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,13 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
var hasMsDi = context
.MetadataReferencesProvider
.Collect()
.Select((refs, _) => refs
.Any(r => (r.Display ?? "")
.Contains("Microsoft.Extensions.DependencyInjection.Abstractions")));
.Select(
(refs, _) => refs
.Any(
r => (r.Display ?? "")
.Contains("Microsoft.Extensions.DependencyInjection.Abstractions")
)
);

var assemblyName = context.CompilationProvider
.Select((cp, _) => cp.AssemblyName!
Expand All @@ -27,9 +31,11 @@ public void Initialize(IncrementalGeneratorInitializationContext context)

var @namespace = context
.AnalyzerConfigOptionsProvider
.Select((c, _) => c.GlobalOptions
.TryGetValue("build_property.rootnamespace", out var ns)
? ns : null);
.Select(
(c, _) => c.GlobalOptions
.TryGetValue("build_property.rootnamespace", out var ns)
? ns : null
);

var behaviors = context.SyntaxProvider
.ForAttributeWithMetadataName(
Expand All @@ -43,8 +49,9 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
var handlers = context.SyntaxProvider
.ForAttributeWithMetadataName(
"Immediate.Handlers.Shared.HandlerAttribute",
predicate: (_, _) => true,
TransformHandler);
predicate: (node, _) => node is TypeDeclarationSyntax,
TransformHandler
);

var handlerNodes = handlers
.Combine(behaviors)
Expand All @@ -58,7 +65,8 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
handler: node.Left.Left,
behaviors: node.Left.Right,
hasMsDi: node.Right,
template)
template
)
);

var registrationNodes = handlers
Expand All @@ -67,7 +75,8 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
.Combine(behaviors)
.Combine(@namespace
.Combine(hasMsDi)
.Combine(assemblyName));
.Combine(assemblyName)
);

context.RegisterSourceOutput(
registrationNodes,
Expand Down
Loading