Skip to content

Conversation

@viceroypenguin
Copy link
Member

No description provided.

@viceroypenguin viceroypenguin requested a review from Copilot July 23, 2025 02:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the handler analyzers to support both static and instance handler methods, replacing the previous static-only requirement. The changes include new validation rules for instance handlers and comprehensive test coverage for both handler types.

  • Removes the requirement for handler methods to be static, allowing both static and instance handlers
  • Adds new analyzer rules for instance handler validation (sealed classes, private members, parameter validation)
  • Updates existing analyzer logic to handle both static and instance handler patterns

Reviewed Changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
HandlerClassAnalyzer.cs Core analyzer logic updated to support both static and instance handlers with new validation rules
TransformHandler.cs Updated ValueTask return type validation logic with more precise namespace checking
DiagnosticIds.cs Added new diagnostic IDs and removed the static method requirement ID
Multiple test files Comprehensive test coverage for both static and instance handler scenarios
Immediate.Handlers.Analyzers.md Removed documentation for the static method requirement
AnalyzerReleases.Unshipped.md Documents added and removed analyzer rules
launchSettings.json Updated project paths for debugging

@codecov
Copy link

codecov bot commented Jul 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
...mediate.Handlers.Analyzers/HandlerClassAnalyzer.cs 99.32% <100.00%> (+1.85%) ⬆️
.../Immediate.Handlers.Generators/TransformHandler.cs 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@viceroypenguin viceroypenguin merged commit ea3332d into non-static Jul 23, 2025
2 checks passed
@viceroypenguin viceroypenguin deleted the analyzers branch July 23, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants