-
-
Notifications
You must be signed in to change notification settings - Fork 4
Update analyzers for handlers #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the handler analyzers to support both static and instance handler methods, replacing the previous static-only requirement. The changes include new validation rules for instance handlers and comprehensive test coverage for both handler types.
- Removes the requirement for handler methods to be static, allowing both static and instance handlers
- Adds new analyzer rules for instance handler validation (sealed classes, private members, parameter validation)
- Updates existing analyzer logic to handle both static and instance handler patterns
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| HandlerClassAnalyzer.cs | Core analyzer logic updated to support both static and instance handlers with new validation rules |
| TransformHandler.cs | Updated ValueTask return type validation logic with more precise namespace checking |
| DiagnosticIds.cs | Added new diagnostic IDs and removed the static method requirement ID |
| Multiple test files | Comprehensive test coverage for both static and instance handler scenarios |
| Immediate.Handlers.Analyzers.md | Removed documentation for the static method requirement |
| AnalyzerReleases.Unshipped.md | Documents added and removed analyzer rules |
| launchSettings.json | Updated project paths for debugging |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
No description provided.