WIP: Fix #233 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

KodeSage wants to merge 5 commits into Indra-db:main from KodeSage:issue-233

KodeSage commented Feb 19, 2025

No description provided.


          Start work on #233

26fd111

Owner

Indra-db commented Feb 19, 2025

@KodeSage you are working on this? Let me know if you have any questions!

KodeSage added 2 commits

February 24, 2025 15:47


          chores: updated docs

d045c25


          Merge branch 'issue-233' of github.com:KodeSage/Flecs-Rust into issue…

1df267c

…-233

KodeSage marked this pull request as ready for review

February 24, 2025 14:48

Author

KodeSage commented Feb 24, 2025

@Indra-db this has been done, please review.

Owner

Indra-db commented Feb 24, 2025 •

edited

Loading

@KodeSage Hey, I looked at the changes and you're missing quite a few of the requirements. Ensuring that all functions are properly documented and examples to each of them from the EntityView type. EntityView functions are spread to several files inside the entity_view folder. You don't have to do bulk entity builder.

I understand this might be a big task with World type Included, so I'm willing to drop World from the requirements so you can earn the $60 that way.

How does that sound? I'll change the Issue to reflect that

Author

KodeSage commented Feb 24, 2025

@KodeSage Hey, I looked at the changes and you're missing quite a few of the requirements. Ensuring that all functions are properly documented and examples to each of them from the EntityView type. EntityView functions are spread to several files inside the entity_view folder. You don't have to do bulk entity builder.

I understand this might be a big task with World type Included, so I'm willing to drop World from the requirements so you can earn the $60 that way.

How does that sound? I'll change the Issue to reflect that

alright sure @Indra-db , I would work on that and improve it.

KodeSage added 2 commits

February 28, 2025 03:18


          chores: updated file entity_view_impl.rs

7c746ff


          chores: updated file entity_view_mut.rs

a214c62

Author

KodeSage commented Feb 28, 2025

@Indra-db I just pushed up.
sorry if this took longer than expected, was just trying to make sure that things are done well and properly.

Author

KodeSage commented Mar 3, 2025

hello @Indra-db , checking in regarding this

Indra-db reviewed

View reviewed changes

flecs_ecs/src/core/entity_view/entity_view_const.rs

    
                  }

                  /// Returns the entity symbol.

                  ///

Owner

Indra-db Mar 10, 2025

missing example

Indra-db reviewed

View reviewed changes

flecs_ecs/src/core/entity_view/entity_view_const.rs

    
                  /// # See also

                  ///

                  /// * C++ API: `entity_view::path_from`

                  #[doc(alias = "entity_view::path_from")]

Owner

Indra-db Mar 10, 2025

missing example

Indra-db reviewed

View reviewed changes

flecs_ecs/src/core/entity_view/entity_view_const.rs

    
                  /// # See also

                  ///

                  /// * C++ API: `entity_view::enabled`

                  #[doc(alias = "entity_view::enabled")]

Owner

Indra-db Mar 10, 2025

missing example

Indra-db reviewed

View reviewed changes

flecs_ecs/src/core/entity_view/entity_view_const.rs

    
                  /// * `func` - The function invoked for each child. Must match the signature `FnMut(EntityView)`.

                  ///

                  /// # See also

                  ///

Owner

Indra-db Mar 10, 2025

see also not done (relate to other similar fns)

Indra-db reviewed

View reviewed changes

flecs_ecs/src/core/entity_view/entity_view_const.rs

    
                  /// # See also

                  ///

                  /// * C++ API: `entity_view::children`

                  #[doc(alias = "entity_view::children")]

Owner

Indra-db Mar 10, 2025

relative to other fns not done

Author

KodeSage commented Mar 10, 2025

@Indra-db , Alright, that's all yeah?

Owner

Indra-db commented Mar 10, 2025

@Indra-db , Alright, that's all yeah?

@KodeSage there's API references missing with See also, and not all public API functions have examples. I'm unclear how to proceed with this bounty.

Is the issue not clear?

Owner

Indra-db commented Mar 10, 2025

this was the acceptance criteria

Author

KodeSage commented Mar 10, 2025 •

edited

Loading

Oh wow, this is quite alot!
I do not think I will be able to finishe up anytime soon.

you can as well give it to the next person to work on.

KodeSage closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet