Adjust screen gamma and fix UI colors #971
Conversation
|
I'd split the PR into two and do here just the gamma correction (to be more color accurate), and in another one the color changes (color is very subjective and I think discussion about color taste may block the gamma change part of this PR) |
|
@NeroBurner Fair. The color changes will require more work. I've now tried to match the colors closer, apart from a few changes which I consider fixes. They are also in #978. Swapping arc colors, brightening steps label and creating a default background for a bar. Since I had to touch those colors anyway, I decided to fix them too. |
swapping colors , is not fix colors , is changing the theming of infinitme to suit your taste and none will be able to rebuke them since they will say that , like you , they are fix the colors... |
I think this concern has been answered in the thread at #978. |
| txtManDist = lv_label_create(lv_scr_act(), nullptr); | ||
| lv_label_set_long_mode(txtManDist, LV_LABEL_LONG_BREAK); | ||
| lv_obj_set_style_local_text_color(txtManDist, LV_LABEL_PART_MAIN, LV_STATE_DEFAULT, LV_COLOR_GREEN); | ||
| lv_obj_set_style_local_text_color(txtManDist, LV_LABEL_PART_MAIN, LV_STATE_DEFAULT, LV_COLOR_MAKE(0x00, 0xc0, 0x00)); |
There was a problem hiding this comment.
why define LV_PINTEIMTE_COLOR_GREEN and then use LV_COLOR_MAKE in the code? I don't understand
There was a problem hiding this comment.
None of the other theme defined colors are used in code either. I don't think lv_pinetime_theme.h is the best place to keep our colors, so I didn't want to use that. Ideally we would have the colors in some cpp format, but then they can't be included in the C theme file. I thought this issue should be resolved separately.
|
Here are screenshots of how this affects the simulator. It's now very close to how it looks like on the watch. Very dark colors still look a bit too dark on the simulator, like on the QuickSettings screen.
|
|
Closed in favor of #1103 |
3 participants
The PineTime screen has poor gamma by default. This is why the colors look very different when simulated on a computer with more accurate colors #743.
Here I've adjusted the gamma of the screen and tweaked the colors to match what they previously looked like by eye. It's not perfect, but hopefully close enough.
Fixes #745