Skip to content

Twig 3 Compat #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2020
Merged

Twig 3 Compat #11

merged 1 commit into from
Oct 20, 2020

Conversation

@kasn
Copy link

@kasn kasn commented Oct 19, 2020 •
edited
Loading

  • allow twig 3
  • php needs to be at least 7.2.5 now, because of twig 3. this will unfortunately require a new mayor release

@jusurb
Copy link

jusurb commented Oct 19, 2020

why not bump it all the way to 7.4?

@kasn
Copy link
Author

kasn commented Oct 19, 2020

We don't need 7.4 features for now. I've looked a bit into proper type hinting, but thats seems like a can of worms I really don't want to deal with now

@kasn kasn merged commit 42b9787 into InterNations:master Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kasn @jusurb