-
Notifications
You must be signed in to change notification settings - Fork 25
Add certificates support in createCompatibleSignedTx.
#691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add certificates support in createCompatibleSignedTx.
#691
Conversation
2b524fd to
1700b02
Compare
5ba5b1f to
df09cd9
Compare
1192ecc to
2bf3997
Compare
createCompatibleSignedTx.
smelc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaving the approval to @Jimbo4350 because I'm not super familiar with the underlying logic but LGTM from a high-level point of view.
Jimbo4350
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! You can squash the commits.
60194a8 to
7d89505
Compare
7d89505 to
9079865
Compare
9079865 to
fa8ccc1
Compare
Changelog
Context
This PR provides certificates support in
createCompatibleSignedTx.Checklist