Skip to content

Add minimal API for creating transactions #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Add minimal API for creating transactions #893

merged 1 commit into from
Jul 14, 2025

Conversation

@palas
Copy link
Contributor

@palas palas commented Jul 7, 2025 •
edited
Loading

Changelog

- description: |
    Add basic transaction creation functions to wasm API
  type:
  - feature

Context

This PR builds on #852 and adds a basic API to cardano-wasm to allow creation of very simple transactions.

How to trust this PR

It think the best way is testing it, and also checking the code structure is sensible.

You can see the tests in #894.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@palas palas self-assigned this Jul 7, 2025
@palas palas force-pushed the cardano-wasm-api branch 2 times, most recently from 8deb081 to 0eb16be Compare July 7, 2025 15:42
@palas palas mentioned this pull request Jul 7, 2025
Merged
3 tasks
@palas palas requested a review from a team as a code owner July 7, 2025 15:58
@palas palas force-pushed the cardano-wasm-api branch 2 times, most recently from 0deffa9 to 3fbaf57 Compare July 7, 2025 16:06
Jimbo4350
Jimbo4350 reviewed Jul 7, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, few minor comments

@palas palas force-pushed the cardano-wasm-api branch from 3fbaf57 to 4abb2e9 Compare July 8, 2025 12:10
@palas palas force-pushed the cardano-wasm-api branch 2 times, most recently from 964bee1 to 3154b1b Compare July 8, 2025 12:45
This was referenced Jul 8, 2025
Closed
Open
@palas palas force-pushed the cardano-wasm-api branch from 3154b1b to 5aa2bb6 Compare July 8, 2025 13:13
Base automatically changed from cardano-wasm to master July 8, 2025 13:28
@palas palas requested a review from Jimbo4350 July 8, 2025 13:29
Jimbo4350
Jimbo4350 approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Pablo 👍

carbolymer
carbolymer reviewed Jul 8, 2025
View reviewed changes
carbolymer
carbolymer reviewed Jul 8, 2025
View reviewed changes
carbolymer
carbolymer reviewed Jul 8, 2025
View reviewed changes
@carbolymer
Copy link
Contributor

carbolymer commented Jul 8, 2025

Could you add CHANGELOG.md file for cardano-wasm and reference it from a top level CHANGELOG.md?

@palas palas force-pushed the cardano-wasm-api branch 3 times, most recently from 03a6c23 to ca515f1 Compare July 8, 2025 20:07
@palas palas requested a review from carbolymer July 8, 2025 20:17
carbolymer
carbolymer reviewed Jul 9, 2025
View reviewed changes
carbolymer
carbolymer reviewed Jul 9, 2025
View reviewed changes
carbolymer
carbolymer requested changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think implementation of signed transaction CBOR serialisation is within the scope of this PR.

@palas palas mentioned this pull request Jul 10, 2025
Merged
3 tasks
@palas palas force-pushed the cardano-wasm-api branch from ca515f1 to 8509842 Compare July 14, 2025 11:00
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 14, 2025
View reviewed changes
@palas palas force-pushed the cardano-wasm-api branch from 8509842 to a08ae57 Compare July 14, 2025 11:41
@palas palas requested a review from carbolymer July 14, 2025 11:44
@palas palas force-pushed the cardano-wasm-api branch from a08ae57 to 69b1574 Compare July 14, 2025 12:51
carbolymer
carbolymer reviewed Jul 14, 2025
View reviewed changes
carbolymer
carbolymer reviewed Jul 14, 2025
View reviewed changes
carbolymer
carbolymer reviewed Jul 14, 2025
View reviewed changes
@palas palas force-pushed the cardano-wasm-api branch from 69b1574 to ffcd9aa Compare July 14, 2025 13:12
carbolymer
carbolymer reviewed Jul 14, 2025
View reviewed changes
@palas palas force-pushed the cardano-wasm-api branch from ffcd9aa to ac7b01d Compare July 14, 2025 13:43
@palas palas enabled auto-merge July 14, 2025 13:49
@palas palas added this pull request to the merge queue Jul 14, 2025
Merged via the queue into master with commit a8fca4f Jul 14, 2025
29 checks passed
@palas palas deleted the cardano-wasm-api branch July 14, 2025 14:43
@palas palas mentioned this pull request Jul 14, 2025
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carbolymer carbolymer carbolymer approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara CarlosLopezDeLara is a code owner

@dcoutts dcoutts Awaiting requested review from dcoutts dcoutts is a code owner

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

Assignees

@palas palas

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@palas @carbolymer @Jimbo4350