Skip to content

Conversation

@palas
Copy link
Contributor

@palas palas commented Jul 17, 2025

Changelog

- description: |
    Added playwright test to `cardano-wasm` and `.#playwright` development shell
  type:
  - test
  projects:
  - cardano-wasm

Context

One of the objectives of input-output-hk/cardano-node-wiki#75 is to ensure that the JavaScript library can be used easily in vanilla JS (from the browser). This PR adds a playwright test that verifies the example in the example folder outputs what is expected when run exclusively on the browser.

As part of this work, this PR also adds a development shell nix develop .#playwright that includes the python server and the playwright setup for facilitating testing.

How to trust this PR

It is a test, so it passing it already gives a lot of assurance. You could modify the test to verify it indeed fails. And I would check that the code structure is appropriate and that there is no dead code. You can also check that the shell works for you, but hydra should do that automatically.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM however I would have a look at Quickstrom as well.

@palas palas force-pushed the cardano-wasm-playwright branch from e41b29b to 6b9156c Compare July 18, 2025 16:31
@palas palas force-pushed the cardano-wasm-typescript branch from 9556681 to 50928d4 Compare July 18, 2025 16:38
@palas palas force-pushed the cardano-wasm-playwright branch from 6b9156c to fafa534 Compare July 18, 2025 16:38
@palas palas force-pushed the cardano-wasm-typescript branch from 50928d4 to bb53acb Compare July 18, 2025 16:42
@palas palas force-pushed the cardano-wasm-playwright branch from fafa534 to d4afa35 Compare July 18, 2025 16:43
@palas palas force-pushed the cardano-wasm-playwright branch from d4afa35 to 2f4f1cf Compare July 18, 2025 16:52
Base automatically changed from cardano-wasm-typescript to master July 18, 2025 18:02
@palas palas added this pull request to the merge queue Jul 18, 2025
Merged via the queue into master with commit 6e6486d Jul 18, 2025
30 checks passed
@palas palas deleted the cardano-wasm-playwright branch July 18, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants