Experimental api propagation 2025-05-28 #1205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equiredUtxoBackwardCompatible on `IsEra era`
Jimbo4350
requested review from
carbolymer,
disassembler,
kevinhammond,
newhoggy and
palas
as code owners
Jimbo4350
changed the title
Jimbo4350
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
2 times, most recently
from
647a31a to
8d9105b
Compare
runTransactionBuildCmd runTransactionBuildEstimateCmd runTransactionBuildRawCmd
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
from
e6af8fe to
b5d9817
Compare
Jimbo4350
changed the title
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
from
2eccab0 to
3bcd66c
Compare
newhoggy
reviewed
Jun 2, 2025
newhoggy
reviewed
Jun 2, 2025
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
from
3bcd66c to
b4ebdbc
Compare
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
from
b4ebdbc to
8a6462a
Compare
carbolymer
reviewed
Jun 2, 2025
carbolymer
reviewed
Jun 2, 2025
carbolymer
requested changes
Jun 2, 2025
cardano-cli/test/cardano-cli-golden/Test/Golden/Latest/Transaction/CalculateMinFee.hs
Outdated
Show resolved
Hide resolved
|
|
||
| import Data.Text (Text) | ||
|
|
||
| toTxOutInAnyEra |
Contributor
There was a problem hiding this comment.
Regarding the name, isn't that the other way around? If input-output-hk/cardano-node-wiki#74 gets accepted, this should be called: txOutInAnyEraToTxOut or fromTxOutInAnyEra.
Contributor
Author
There was a problem hiding this comment.
It's poorly named but I want to wait till after 74 gets adopted before making the change.
carbolymer
reviewed
Jun 2, 2025
| noteInputFile | ||
| "test/cardano-cli-golden/files/input/shelley/transaction-calculate-min-fee/protocol-params.json" | ||
| txBodyFile <- noteInputFile "test/cardano-cli-golden/files/input/shelley/tx/txbody" | ||
| "test/cardano-cli-test/files/input/calculate-min-fee/flags-protocol-params-preview.json" |
Contributor
There was a problem hiding this comment.
cardano-cli-test file used in golden tests. Breaks hydra.
carbolymer
requested changes
Jun 2, 2025
carbolymer
reviewed
Jun 2, 2025
cardano-cli/test/cardano-cli-golden/Test/Golden/Latest/Transaction/CalculateMinFee.hs
Outdated
Show resolved
Hide resolved
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
4 times, most recently
from
15fec33 to
7cc587e
Compare
carbolymer
reviewed
Jun 3, 2025
| , outFile | ||
| } = do | ||
| let sbe = convert eon -- TODO: Conway era - update vote creation related function to take ConwayEraOnwards | ||
| let sbe = convert era -- TODO: Conway era - update vote creation related function to take ConwayEraOnwards |
Contributor
There was a problem hiding this comment.
careateVotingProcedure is accepting ConwayEraOnwards already so convert = id here AFAIU
Contributor
Author
There was a problem hiding this comment.
era here is the experimental Era era
carbolymer
reviewed
Jun 3, 2025
| ["--output-json", "--out-file"] -> do | ||
| jsonOnDisk :: Aeson.Value <- H.readJsonFileOk outFileFp | ||
| H.diff jsonOnDisk (==) (Aeson.object ["fee" .= (2050100 :: Int)]) | ||
| H.diff jsonOnDisk (==) (Aeson.object ["fee" .= (247473 :: Int)]) |
Contributor
There was a problem hiding this comment.
Why the fee has changed?
Contributor
Author
There was a problem hiding this comment.
I am using a Conway era transaction now. Previously it was Babbage.
carbolymer
approved these changes
Jun 3, 2025
Contributor
carbolymer
left a comment
carbolymer
left a comment
There was a problem hiding this comment.
Nice 👍🏻 It's looking cleaner.
Jimbo4350
force-pushed
the
jordan/experimental-api-propagation-20250528
branch
from
7cc587e to
84c1bb0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.
How to trust this PR
Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.
Checklist