-
Notifications
You must be signed in to change notification settings - Fork 22
Add check-node-configuration command #923
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c740c1f to
9a6f631
Compare
66c8ef2 to
9d4dba7
Compare
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
4be047d to
212c3d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think I'll leave the approval to @Jimbo4350
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
d8c18e5 to
5b42105
Compare
|
Putting back to draft while I change the code to use |
f64d941 to
682dc9a
Compare
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
cardano-cli/src/Cardano/CLI/Run/Debug/CheckNodeConfiguration.hs
Outdated
Show resolved
Hide resolved
7ed8319 to
78c0fe5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also we need to come up with a better name than Analysis.
78c0fe5 to
2e88aae
Compare
Renamed to |
27126cd to
637e846
Compare
637e846 to
f6d4b34
Compare
d4a4536 to
622f434
Compare
622f434 to
38f2ef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! One requested change.
|
|
||
| -- | Semaphore protecting against locked file error, when running properties concurrently. | ||
| nodeConfigSem :: FileSem | ||
| nodeConfigSem = newFileSem "test/cardano-cli-test/files/input/check-node-configuration/node-config.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these tests actually run concurrently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes parallelism happens even within a single file. cc @carbolymer
Changelog
Context
How to trust this PR
Try it yourself:
cabal run cardano-cli -- debug check-node-configuration --node-configuration-file node-config.jsonnode-config.jsonfile. Rerun the command and observe that it detects the change.Checklist