Test SPO vote counting #4700
Merged
Test SPO vote counting #4700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
4 times, most recently
from
2cde68d to
d7e9320
Compare
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
9 times, most recently
from
bf58a41 to
913d87d
Compare
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
2 times, most recently
from
0d7381b to
c5c631d
Compare
aniketd
reviewed
Nov 4, 2024
Contributor
aniketd
left a comment
aniketd
left a comment
There was a problem hiding this comment.
Just a few minor suggestions. LGTM! 👍
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
2 times, most recently
from
fe2d6d0 to
b0bc17c
Compare
Contributor
Author
|
Note to whoever takes this over as I'm off this week: I reinstated the previously removed tests in the last commit. I only adjusted them minimally, so they pass. I think the one with the |
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
from
b0bc17c to
55277d8
Compare
lehins
reviewed
Nov 12, 2024
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
eras/conway/impl/test/Test/Cardano/Ledger/Conway/SPORatifySpec.hs
Outdated
Show resolved
Hide resolved
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
2 times, most recently
from
4de44d3 to
d8d0f53
Compare
Contributor
Author
|
Regarding #4727, I dropped the |
Lucsanszky
force-pushed
the
ldan/spo-voting-tests
branch
from
d8d0f53 to
76e800a
Compare
* Assert that the default vote is `Abstain` in general
* Assert that `HardForkInitiation` is an exception to the above
and default vote is `No` in this case
* Assert that default vote is `No` in general
* Assert that default vote is `No` for `HardForkInitiation`
and this cannot be overruled by the new default vote customisation
* Assert that the default vote can be customised by delegating
a pool's reward account to:
- An `AlwaysNoConfidence` DRep, in which case the default vote
becomes `Yes` for a `NoConfidence` action
- An `AlwaysAbstain` DRep, in which case the default vote
become `Abstain` in general
lehins
force-pushed
the
ldan/spo-voting-tests
branch
from
76e800a to
214fef4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-up for #4659
Resolves #4617
Resolves #4727
Checklist
CHANGELOG.mdfor the affected packages.New section is never added with the code changes. (See RELEASING.md)
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated.If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)
fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)