Skip to content

Adjust semantics of ConwayWdrlNotDelegatedToDRep #4715

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Adjust semantics of ConwayWdrlNotDelegatedToDRep #4715

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2b1163d
Adjust semantics of `ConwayWdrlNotDelegatedToDRep`
lehins Oct 23, 2024
946ec12
Add a test case for recent changeof ConwayWdrlNotDelegatedToDRep sema…
lehins Oct 23, 2024
2fd3a76
Fix using a wrong deposit for stake pools in the ImpSpec
lehins Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Adjust semantics of ConwayWdrlNotDelegatedToDRep 
Previous semantics did not allow to withdraw rewards and deregister in
the same transaction, because deregistration would effectively clear
out delegation to a DRep, thus preventing withdrawals
  • Loading branch information
@lehins
lehins committed Oct 23, 2024
commit 2b1163d40fc6ee9b11dc9e3f3d39ea170ba16456
4 changes: 4 additions & 0 deletions eras/conway/impl/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@

* Add `whenBootstrap`

## 1.17.2.0

* Change the state used for `ConwayWdrlNotDelegatedToDRep` predicate failure checking

## 1.17.1.0

* Add `processDelegation`
Expand Down
24 changes: 15 additions & 9 deletions eras/conway/impl/src/Cardano/Ledger/Conway/Rules/Ledger.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,17 +417,15 @@ ledgerTransition = do
committee = govState ^. committeeGovStateL
proposals = govState ^. proposalsGovStateL
committeeProposals = proposalsWithPurpose grCommitteeL proposals
certStateAfterCERTS <-
trans @(EraRule "CERTS" era) $
TRC
( CertsEnv tx pp slot currentEpoch committee committeeProposals
, certState
, StrictSeq.fromStrict $ txBody ^. certsTxBodyL
)

-- Starting with version 10, we don't allow withdrawals into RewardAcounts that are KeyHashes and not delegated to Dreps
-- Starting with version 10, we don't allow withdrawals into RewardAcounts that are
-- KeyHashes and not delegated to Dreps.
--
-- We also need to make sure we are using the certState before certificates are applied,
-- because otherwise it would not be possible to unregister a reward account and withdraw
-- all funds from it in the same transaction.
unless (HF.bootstrapPhase (pp ^. ppProtocolVersionL)) $ do
let dUnified = dsUnified $ certDState certStateAfterCERTS
let dUnified = dsUnified $ certDState certState
wdrls = unWithdrawals $ tx ^. bodyTxL . withdrawalsTxBodyL
delegatedAddrs = DRepUView dUnified
wdrlsKeyHashes =
Expand All @@ -437,6 +435,14 @@ ledgerTransition = do
Set.filter (not . (`UMap.member` delegatedAddrs) . KeyHashObj) wdrlsKeyHashes
failOnNonEmpty nonExistentDelegations ConwayWdrlNotDelegatedToDRep

certStateAfterCERTS <-
trans @(EraRule "CERTS" era) $
TRC
( CertsEnv tx pp slot currentEpoch committee committeeProposals
, certState
, StrictSeq.fromStrict $ txBody ^. certsTxBodyL
)

-- Votes and proposals from signal tx
let govSignal =
GovSignal
Expand Down
Loading