Adding Example Smart Contracts and Traces. #955
Conversation
There was a problem hiding this comment.
I left some comments here and there.
@williamdemeo and I had discussed with @Ali-Hill that probably it will be better to move all the examples to its own hierarchy outside of src. Maybe in a folder called src-ext-test.
There was a problem hiding this comment.
Since the contents of this file relate to scripts I suggest to move it to the Script folder.
I see two options:
- Merge it with
Script.Base - Replace
Script.Baseby this module and move the currentScript.BasetoScript.Structure(or something along those lines)
There was a problem hiding this comment.
@carlostome I think the first option will create a cyclic module dependency so we could either go with the second option, or we could simply move the ScriptPurpose.agda file into Specification/Script/ (and, incidentally, we should rename it ScriptPurpose.lagda.md). For now I'll do the latter, since it has less impact.
| ⦃ Dec-validPlutusScript ⦄ : ∀ {x} → (validPlutusScript x ⁇³) | ||
| language : PlutusScript → Language | ||
| toData : ∀ {A : Type} → A → Data | ||
| -- toData : ∀ {A : Type} → A → Data |
There was a problem hiding this comment.
Why is this commented out?
| -- valContext : TxInfo → ScriptPurpose → Data | ||
| -- valContext txinfo sp = toData (txinfo , sp) |
There was a problem hiding this comment.
Why are these lines commented out?
| --valContext : TxInfo → ScriptPurpose → Data | ||
| --valContext txinfo sp = toData (txinfo , sp) |
There was a problem hiding this comment.
Why are these lines commented out?
|
I agree, it could even be factored into a separate library. |
Proposed refactor for IntersectMBO#955: reorganize & rename files
4 participants
Description
Reimplements the changes in Alasdair's PR #885 modernized for the most recent commit of the master branch.
Additionally adds three more example contracts and their respective traces to the Conway specification tests including:
Development notes:
All examples currently only use coinTokenAlgebra, because the more complex Token Algebras cause the computational traces to hang endlessly. Attempted to use the proposed fixed-length vector implementation as well as a simplified version with just Ada and one singular token with no success. This makes the Distributed Exchange a bit weird since it does not have different currencies to exchange, but should be easily adaptable once Token Algebras are fully implemented.
As part of the previous changes, we removed
toData, which will need to be reflected in the spec of Djikstra going forward.Checklist
CHANGELOG.md