Fixes assignment of NodeToClientV_19 to ShelleyNodeToClientVersion11 #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
requested review from
amesgen,
dnadales,
fraser-iohk,
jasagredo and
nfrisby
as code owners
Contributor
|
You need to update the golden files. Run |
amesgen
requested changes
Nov 14, 2024
Member
There was a problem hiding this comment.
Thanks, I missed this in #1067!
We also need to introduce CardanoNodeToClientVersion15 and use it here
where
CardanoNodeToClientVersion15 is a copy ofwith
ShelleyNodeToClientVersion11.
All of this is fine because NodeToClientV_19 hasn't been released yet.
crocodile-dentist
force-pushed
the
mwojtowicz/shelleynodetoclientversion-fix
branch
2 times, most recently
from
43811e0 to
a23e03e
Compare
amesgen
approved these changes
Nov 14, 2024
amesgen
force-pushed
the
mwojtowicz/shelleynodetoclientversion-fix
branch
from
a23e03e to
26bb95e
Compare
Member
|
Pushed a minor fix in the tests and squashed the commits 👍 |
crocodile-dentist
force-pushed
the
mwojtowicz/shelleynodetoclientversion-fix
branch
from
26bb95e to
2316e4d
Compare
amesgen
force-pushed
the
mwojtowicz/shelleynodetoclientversion-fix
branch
from
2316e4d to
97a74c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NodeToClientV_19 should map to ShelleyNodeToClientVersion11 for GetBigLedgerPeerSnapshot query.