Skip to content

Shelley mempool per-tx size check: do not include perTxOverhead #1352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Shelley mempool per-tx size check: do not include perTxOverhead #1352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Shelley mempool per-tx size check: do not include perTxOverhead 
See the PR description for details
  • Loading branch information
@amesgen
amesgen committed Jan 7, 2025
commit 992a85530ea1245f585754e15e865fac1e303518
4 changes: 4 additions & 0 deletions ...ano/changelog.d/20250107_124744_alexander.esgen_shelley_mempool_txsize_check.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Patch

- Fixed a bug where a valid tx with less than `4` bytes less than the max tx
size would be incorrectly rejected by the mempool.
4 changes: 2 additions & 2 deletions ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/Mempool.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,9 +328,9 @@ txInBlockSize ::
txInBlockSize st (ShelleyTx _txid tx') =
validateMaybe (maxTxSizeUTxO txsz limit) $ do
guard $ txsz <= limit
Just $ IgnoringOverflow $ ByteSize32 $ fromIntegral txsz
Just $ IgnoringOverflow $ ByteSize32 $ fromIntegral txsz + perTxOverhead
where
txsz = perTxOverhead + (tx' ^. sizeTxF)
txsz = tx' ^. sizeTxF

pparams = getPParams $ tickedShelleyLedgerState st
limit = fromIntegral (pparams ^. L.ppMaxTxSizeL) :: Integer
Expand Down
Loading