Skip to content

Make egress poll interval configurable #5113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2025
Merged

Make egress poll interval configurable #5113

merged 1 commit into from
May 8, 2025

Conversation

@karknu
Copy link
Contributor

@karknu karknu commented Apr 23, 2025

Description

Make the egress queue's poll interval configurable.
Polling the egress queue is a trade between requests latency on one side and CPU and Network efficiency on the other.
By making it configurable node operators can tailor to their preference.

Checklist

Quality

  • Commit sequence makes sense and have useful messages, see ref.
  • New tests are added and existing tests are updated.
  • Self-reviewed the PR.

Maintenance

  • Linked an issue or added the PR to the current sprint of ouroboros-network project.
  • Added labels.
  • Updated changelog files.
  • The documentation has been properly updated, see ref.

@github-project-automation github-project-automation bot moved this to In Progress in Ouroboros Network Apr 23, 2025
@karknu karknu force-pushed the karknu/conf_egre_int branch 4 times, most recently from 25c866e to dc88b72 Compare April 24, 2025 05:38
@karknu karknu marked this pull request as ready for review April 24, 2025 08:00
@karknu karknu requested a review from a team as a code owner April 24, 2025 08:00
coot
coot approved these changes Apr 24, 2025
View reviewed changes
Copy link
Collaborator

@coot coot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karknu karknu enabled auto-merge April 24, 2025 13:40
@karknu karknu disabled auto-merge May 8, 2025 05:33
@karknu karknu force-pushed the karknu/conf_egre_int branch from dc88b72 to ca60b86 Compare May 8, 2025 07:55
@karknu karknu enabled auto-merge May 8, 2025 08:47
@karknu
Make egress poll interval configurable
afd196a 
Make the egress queue's poll interval configurable.
@karknu karknu force-pushed the karknu/conf_egre_int branch from ca60b86 to afd196a Compare May 8, 2025 10:13
@karknu karknu added this pull request to the merge queue May 8, 2025
Merged via the queue into main with commit d49c0a5 May 8, 2025
38 of 39 checks passed
@karknu karknu deleted the karknu/conf_egre_int branch May 8, 2025 17:02
@github-project-automation github-project-automation bot moved this from In Progress to Done in Ouroboros Network May 8, 2025
@crocodile-dentist crocodile-dentist added the mux issues related to network-mux label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coot coot coot approved these changes

Assignees

@karknu karknu

Labels

mux issues related to network-mux

Projects

Ouroboros Network
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@karknu @coot @crocodile-dentist