modified to use the missing_values argument value in the output#70
Closed
kwombach wants to merge 1 commit intoJ535D165:masterfrom
Closed
modified to use the missing_values argument value in the output#70kwombach wants to merge 1 commit intoJ535D165:masterfrom
kwombach wants to merge 1 commit intoJ535D165:masterfrom
Conversation
Owner
|
Thanks a lot for sharing this issue! This is definitively a bug. I'm not completely convinced that the code you propose here is the solution. Are you interested in writing a unit test? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very minor change that I made for my purposes. When performing string comparisons, if a missing_values argument is provided in addition to the threshold argument, the missing_values value will not appear in the output because the threshold code returns True or False (is then converted to 0.0 and 1.0). I believe this is a mistake because it make it impossible to delineate between pairs that did not match and pairs that contained a missing value.
Hope this helps!
Kai Wombacher