Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merged master branch from apache #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
Merged master branch from apache #1
Changes from 1 commit
767ea8671133e12cb962b9689c44637f593ba92de04aee19e3f4c32b345c38095db7e691bd3842e1e1f894849af2bdb26b7f6dee803191e8d04b46712abfe7074f770978cd0bfd08c93c8d78a77a06cdda74f60170b606f8dc455b1d1ed3e7f34035425dc582d161cbd37d18d0c2e9b9dc7d41e00f06dd9a6d773e55ff83bad4b6ff4926d1670c365aa0d00db6bb24cb219e379c956ab1e64b4f3614448eb9a439e08c40f83f753ee8d6992c7e18ad81c3cc2d259f9397ec57e4f309ce43ad939b6350f58e9e700355c39981dbaede6093956860efe548e66cb17a0e6bb5459fc0972de7242d7fb22d54a7f7a3d86c587d204e23054d2b5596ab00484fcbf5947f868786238d0cab205e7582dc820d68dcfdccd889af338ce503b9ca9345a0b2a2b5d44c1387166cc62bcac7331f150b9b108e7f5b1353f6f782ef2d6467d38ef477d572a8574afc68c0a3c0c84026d7bdac1911db031fc59988af0090461b609c70df3b50f738fe07779fce7f51106eb08b90c4ad86f2d2f46755dea2d4ff9f1f16d223e592230e26a8d2f5b77ebb0769049abb1f0c10c2b68253a1ae046c8c356bb81526a5e338b62c290bcf34886d3bb5403e47974b93267713565529b875132cbf0068b6c87b78e344e3daa5738cf7f8a5af37e8bf8fe77e9152ac8813e11ea25539889df4e8701a72e238a6ce1b16cfc0495caa46cecd689c9335f00b2a8d7ed44b7931be6ecb654e0aa18aaa9e8176218b120c3895ecb112a2927cb9b387a17fd3f8ff550e03bbdbe0f4fe4b6579703180126924a0c76a819661f65c67d0c3f5a209c6d3f376cd5cf5dfb3343bb93547482b43de834ef794bbca342f59ca33c1034e83910fcf2c4ba9aa18df72d3266d3b92ee2634dba6f0ef9333fbf56b4ec9e2f47e0f8323a6e8b02578006c4009e31bef15b65d8a620f07238eb5a62c8ced9245dce120d3224d8089567182f8cd2a535f8b94eff44bd0a8c4ca2327c9a9ec2b6640ab59d5abaf0d99c78221bda189be87e3446aecb48cc82c520ad92018eed05954402375b101b0ccb52d47a7bcadedf156a95dac6f1777b7fe1bc95c3ab3c916eae0579a3241aebc0b52da0ab9bd717b59a9dd546495181543c1e995ad1b8bd7b6d57b6f7704ec6c5fcac02c99f16f63057c2e15cc6aa25947d371d26a949d1160b3be8fa739fb6a0a7ef7af9ab9ea55fed4247716218bc568239d194bd480d2fbf0da8032e7File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
### What changes were proposed in this pull request? This PR aims to support driver-owned on-demand PVC(Persistent Volume Claim)s. It means dynamically-created PVCs will have the `ownerReference` to `driver` pod instead of `executor` pod. ### Why are the changes needed? This allows K8s backend scheduler can reuse this later. **BEFORE** ``` $ k get pvc tpcds-pvc-exec-1-pvc-0 -oyaml apiVersion: v1 kind: PersistentVolumeClaim metadata: ... ownerReferences: - apiVersion: v1 controller: true kind: Pod name: tpcds-pvc-exec-1 ``` **AFTER** ``` $ k get pvc tpcds-pvc-exec-1-pvc-0 -oyaml apiVersion: v1 kind: PersistentVolumeClaim metadata: ... ownerReferences: - apiVersion: v1 controller: true kind: Pod name: tpcds-pvc ``` ### Does this PR introduce _any_ user-facing change? No. (The default is `false`) ### How was this patch tested? Manually check the above and pass K8s IT. ``` KubernetesSuite: - Run SparkPi with no resources - Run SparkPi with a very long application name. - Use SparkLauncher.NO_RESOURCE - Run SparkPi with a master URL without a scheme. - Run SparkPi with an argument. - Run SparkPi with custom labels, annotations, and environment variables. - All pods have the same service account by default - Run extraJVMOptions check on driver - Run SparkRemoteFileTest using a remote data file - Verify logging configuration is picked from the provided SPARK_CONF_DIR/log4j.properties - Run SparkPi with env and mount secrets. - Run PySpark on simple pi.py example - Run PySpark to test a pyfiles example - Run PySpark with memory customization - Run in client mode. - Start pod creation from template - PVs with local storage - Launcher client dependencies - SPARK-33615: Launcher client archives - SPARK-33748: Launcher python client respecting PYSPARK_PYTHON - SPARK-33748: Launcher python client respecting spark.pyspark.python and spark.pyspark.driver.python - Launcher python client dependencies using a zip file - Test basic decommissioning - Test basic decommissioning with shuffle cleanup - Test decommissioning with dynamic allocation & shuffle cleanups - Test decommissioning timeouts - Run SparkR on simple dataframe.R example Run completed in 16 minutes, 40 seconds. Total number of tests run: 27 Suites: completed 2, aborted 0 Tests: succeeded 27, failed 0, canceled 0, ignored 0, pending 0 All tests passed. ``` Closes apache#32288 from dongjoon-hyun/SPARK-35182. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing