Skip to content

Update stub for "ibm_db2" #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
isfedorov merged 1 commit into from
Mar 15, 2023
Merged

Update stub for "ibm_db2" #1531

isfedorov merged 1 commit into from
Mar 15, 2023

Conversation

@phansys
Copy link
Contributor

@phansys phansys commented Feb 24, 2023

No description provided.

@phansys phansys marked this pull request as ready for review February 24, 2023 13:50
@phansys
Copy link
Contributor Author

phansys commented Mar 2, 2023

Is there something I can do to fix the CI?

Fatal error: Uncaught PhpParser\Error: Syntax error, unexpected ']', expecting ')' on line 1212 in /opt/project/phpstorm-stubs/vendor/nikic/php-parser/lib/PhpParser/ParserAbstract.php:318

@isfedorov
Copy link
Contributor

isfedorov commented Mar 4, 2023

@phansys yes you can :) you can fix the typo on line 1212 as the failure is caused by it.

function db2_prepare($connection, string $statement, array $options = []]) {}

@phansys
Copy link
Contributor Author

phansys commented Mar 4, 2023

function db2_prepare($connection, string $statement, array $options = []]) {}

🤦‍♂️

Thank you @isfedorov!

isfedorov
isfedorov requested changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@isfedorov isfedorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phansys Thank you for the contribution! Overall PR is good to go, I've left just some comments regarding not updated PHPDocs and a questions regarding stdClass as a return type. Please find them inline

@phansys phansys marked this pull request as draft March 6, 2023 15:25
@phansys phansys marked this pull request as ready for review March 6, 2023 18:07
@phansys phansys requested a review from isfedorov March 15, 2023 02:02
@isfedorov isfedorov merged commit b51c647 into JetBrains:master Mar 15, 2023
@phansys phansys deleted the ibm_db2 branch March 15, 2023 09:41
This was referenced Jun 12, 2023
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@isfedorov isfedorov Awaiting requested review from isfedorov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@phansys @isfedorov