Skip to content

Conversation

@mbakirov
Copy link
Contributor

This PR contain fixes for YAF stubs against https://github.com/laruence/yaf/ repo

@mbakirov
Copy link
Contributor Author

@isfedorov thank you for your comments! I've fixed them all

@mbakirov mbakirov requested a review from isfedorov March 13, 2024 10:55
@mbakirov
Copy link
Contributor Author

mbakirov commented Apr 2, 2024

@isfedorov may I ask your review please?

Copy link
Contributor

@isfedorov isfedorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mbakirov Sorry for the long review. Looks like it's only a couple of final notes left. Could you please take a look at them and we will merge PR after that.

@mbakirov mbakirov requested a review from isfedorov April 3, 2024 09:24
@mbakirov
Copy link
Contributor Author

mbakirov commented Apr 3, 2024

@isfedorov I have removed all @implements phpdoc comments

@isfedorov isfedorov merged commit 1882be0 into JetBrains:master Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants