Skip to content

build: convert eslint.config to typescript and add our plugin #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025
Merged

build: convert eslint.config to typescript and add our plugin #1112

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
45cbec5
build: convert eslint.config to typescript and add our plugin
michaelfaith Jun 14, 2025
b0ebeb1
build: convert eslint.config to typescript and add our plugin
michaelfaith Jun 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions eslint.config.js → eslint.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ import * as regexp from "eslint-plugin-regexp";
import yml from "eslint-plugin-yml";
import tseslint from "typescript-eslint";

import packageJson from "./src/index.js";

export default tseslint.config(
{
ignores: [
Expand All @@ -26,7 +28,9 @@ export default tseslint.config(
},
{ linterOptions: { reportUnusedDisableDirectives: "error" } },
eslint.configs.recommended,
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access -- https://github.com/eslint-community/eslint-plugin-eslint-comments/issues/214
comments.recommended,
// eslint-disable-next-line @typescript-eslint/no-unsafe-argument, @typescript-eslint/no-unsafe-member-access -- https://github.com/eslint-community/eslint-plugin-eslint-plugin/issues/487
eslintPlugin.configs["flat/recommended"],
jsdoc.configs["flat/contents-typescript-error"],
jsdoc.configs["flat/logical-typescript-error"],
Expand Down Expand Up @@ -111,4 +115,8 @@ export default tseslint.config(
"n/no-unsupported-features/node-builtins": "off",
},
},
{
extends: [packageJson.configs.recommended],
files: ["package.json"],
},
);
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"eslint-plugin-regexp": "2.8.0",
"eslint-plugin-yml": "1.18.0",
"husky": "9.1.7",
"jiti": "^2.4.2",
Copy link
Owner

@JoshuaKGoldberg JoshuaKGoldberg Jun 16, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I bet after a while we'll be able to drop this too.

"jsonc-eslint-parser": "2.4.0",
"knip": "5.60.0",
"lint-staged": "16.1.0",
Expand Down
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/tests/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ describe("configs", () => {
const eslint = new ESLint({
baseConfig: plugin.configs.recommended as Linter.Config,
fix: true,
overrideConfigFile: true,
Copy link
Collaborator Author

@michaelfaith michaelfaith Jun 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was necessary after adding our plugin to the root config. Without this, eslint was using our config in the root as part of this test (which wasn't really good to begin with)

});
const code = await readFile(
resolve(import.meta.filename, "../../../package.json"),
Expand Down
Loading