Skip to content

Conversation

@github-actions
Copy link
Contributor

This pull request changes the compat entry for the SpecialFunctions package from 0.7, 0.8, 0.9, 0.10, 1.0 to 0.7, 0.8, 0.9, 0.10, 1.0, 2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@ranocha
Copy link

ranocha commented Nov 23, 2021

It would be nice to get this merged to allow downstream packages to upgrade. A first search indicates that the only breaking change in SpecialFunctions.jl was to remove some method Base.factorial for general number types, see JuliaMath/SpecialFunctions.jl#297 and JuliaMath/SpecialFunctions.jl#361. This package shouldn't be affected directly since there does not seem to be any factorial in here, see https://github.com/JuliaApproximation/FastGaussQuadrature.jl/search?q=factorial&type=code
I wonder why no CI is triggered automatically...

@dlfivefifty
Copy link
Member

CompatHelper for some reason never triggers tests. modifying the branch by bumping the version triggers the tests, once they pass I can merge and tag

@dlfivefifty
Copy link
Member

PS I recommend not worrying about being on the latest version unless there is some feature you absolutely need. A change like this will take weeks to filter down.

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #104 (2791780) into master (e8b1e80) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   97.04%   96.96%   -0.08%     
==========================================
  Files           9        8       -1     
  Lines        1149     1154       +5     
==========================================
+ Hits         1115     1119       +4     
- Misses         34       35       +1     
Impacted Files Coverage Δ
src/gausslaguerre.jl 92.69% <0.00%> (-0.25%) ⬇️
src/FastGaussQuadrature.jl
src/gaussjacobi.jl 99.26% <0.00%> (+<0.01%) ⬆️
src/gausslegendre.jl 98.73% <0.00%> (+<0.01%) ⬆️
src/besselroots.jl 96.12% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8b1e80...2791780. Read the comment docs.

@dlfivefifty dlfivefifty merged commit cb6d71c into master Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants