Skip to content

Using a strong zero in Dual(0.0, 1)^0 to avoid NaN #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dlfivefifty merged 8 commits into from
Apr 3, 2021
Merged

Using a strong zero in Dual(0.0, 1)^0 to avoid NaN #84

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88cb00b
test and fix for nan epsilon of dual^UInt64(0)
jwscook Mar 17, 2021
a331c1f
"0.6.3" -> "0.6.4"
jwscook Mar 17, 2021
3634f5d
removed NaNs, codified behaviour with Ints
jwscook Mar 19, 2021
31b063a
Merge branch 'master' into strongzerosandnonans
jwscook Mar 19, 2021
a27ec35
improve testing, remove type instability
jwscook Mar 21, 2021
89a36a0
merge conflict
jwscook Mar 21, 2021
cdf9682
handle Dual(Integer(1), n)^Integer
jwscook Mar 21, 2021
02aa88f
version semver bump 0.6.4 -> 0.6.5
jwscook Apr 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
handle Dual(Integer(1), n)^Integer
  • Loading branch information
@jwscook
jwscook committed Mar 21, 2021
commit cdf968280cffc8e910a93d79d3e8067c593e4dc6
1 change: 1 addition & 0 deletions src/dual.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,7 @@ function pow(z::Dual, n::AbstractFloat)
end
function pow(z::Dual{T}, n::Integer) where T
iszero(n) && return Dual(one(T), zero(T)) # avoid DomainError Int^(negative Int)
isone(z) && return Dual(one(T), epsilon(z) * n)
return Dual(value(z)^n, epsilon(z) * n * value(z)^(n - 1))
end
# these first two definitions are needed to fix ambiguity warnings
Expand Down
3 changes: 3 additions & 0 deletions test/automatic_differentiation_test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ powwrap(z, n, epspart=0) = Dual(z, epspart)^n
# these ones don't DomainError
@test powwrap(0, 0, 0) == Dual(1, 0) # special case is handled
@test powwrap(0, 0, 1) == Dual(1, 0) # special case is handled
@test powwrap(1, -1) == powwrap(1.0, -1) # special case is handled
@test powwrap(1, -2) == powwrap(1.0, -2) # special case is handled
@test powwrap(1, -123) == powwrap(1.0, -123) # special case is handled
@test powwrap(1, 0) == Dual(1, 1)
@test powwrap(123, 0) == Dual(1, 1)
for i ∈ -3:3
Expand Down