Skip to content

Conversation

@theogf
Copy link
Member

@theogf theogf commented Sep 30, 2021

Summary

Tests were not passing for the ppl directory and it looked like a compat issue. Hopefully this should help

It seems that CompatHelper was not being called for the ppl directory, hopefully adding the full path will help
I also directly updated all the necessary bounds.

Deprecates #168

Proposed changes
Updates Compathelper settings and update the Project.toml so test pass.

What alternatives have you considered?
Leaving it broken and cry.

Breaking changes
Nope

@codecov-commenter
Copy link

Codecov Report

Merging #227 (1df746e) into master (2f4fb60) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   98.03%   98.03%           
=======================================
  Files          10       10           
  Lines         356      356           
=======================================
  Hits          349      349           
  Misses          7        7           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f4fb60...1df746e. Read the comment docs.

@theogf theogf requested a review from devmotion September 30, 2021 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants