Update build.jl to support aa64 macs #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the late review. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw that
build.jlwas looking for the librarylibmxat the wrong subdirectorymaci64instead of the correct onemaca64foat theaa64version ofMATLABWith this change
MATLAB.jlbuilds correctly and all tests passed. It fixes #205 #209Clarification: This should allow MATLAB.jl to build and work correctly for macOS julia-x86 with MATLAB-x86 and julia-aa64 with MATLAB-aa64 (like the R2023b Prerelease). I do not believe that other combinations are possible (or meaningful?).