Skip to content

remove use of jl_set_value on 1.9. fix UndefVarError for new nightly error formatting - #709

Merged
IanButterworth merged 4 commits into
masterfrom
sb/set-value-nightly
Oct 7, 2022
Merged

remove use of jl_set_value on 1.9. fix UndefVarError for new nightly error formatting#709
IanButterworth merged 4 commits into
masterfrom
sb/set-value-nightly

Conversation

@simonbyrne

Copy link
Copy Markdown
Member

Fixes #708 (I hope).

@vtjnash is this the correct usage?

@codecov

codecov Bot commented Aug 1, 2022

Copy link
Copy Markdown

Codecov Report

Merging #709 (a58ebc2) into master (9537cdd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #709   +/-   ##
=======================================
  Coverage   93.42%   93.42%           
=======================================
  Files           2        2           
  Lines         517      517           
=======================================
  Hits          483      483           
  Misses         34       34           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vtjnash

vtjnash commented Aug 1, 2022

Copy link
Copy Markdown
Member

It might be better to call jl_f_setglobal, but this does look the same

@simonbyrne

Copy link
Copy Markdown
Member Author

Error appears to now be

ERROR: LoadError: MethodError: no method matching active_module()
You may have intended to import Base.active_module
The applicable method may be too new: running in world age 17748, while current world is 17759.

Closest candidates are:
  active_module() (method too new to be called from this world context.)
   @ REPL /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/REPL/src/REPL.jl:494
  active_module(::REPL.REPLDisplay) (method too new to be called from this world context.)
   @ REPL /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/REPL/src/REPL.jl:500
  active_module(::REPL.LineEditREPL) (method too new to be called from this world context.)
   @ REPL /opt/hostedtoolcache/julia/nightly/x64/share/julia/stdlib/v1.9/REPL/src/REPL.jl:498
  ...

Stacktrace:
  [1] active_module()
    @ Base ./show.jl:488
  [2] show_type_name(io::IOContext{IOBuffer}, tn::Core.TypeName)
    @ Base ./show.jl:1029
  [3] show_datatype(io::IOContext{IOBuffer}, x::DataType, wheres::Vector{TypeVar})
    @ Base ./show.jl:1082

@simonbyrne

Copy link
Copy Markdown
Member Author

This might be due to JuliaLang/julia#45838? @aviatesk Any suggestions on what we might be able to do here?

@IanButterworth

Copy link
Copy Markdown
Member

bump @aviatesk

@KristofferC

Copy link
Copy Markdown
Member

Error appears to now be

Should be fixed via JuliaLang/julia#46866

@IanButterworth

Copy link
Copy Markdown
Member

1.6 failures are #706

@simonbyrne simonbyrne closed this Oct 7, 2022
@simonbyrne simonbyrne reopened this Oct 7, 2022
@simonbyrne

simonbyrne commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

This line is failing on Windows x86 1.7:

rm(joinpath(new_depot, "artifacts"); recursive=true)

@IanButterworth

Copy link
Copy Markdown
Member

pushed fix for test breakage due to JuliaLang/julia#47077

@IanButterworth

IanButterworth commented Oct 7, 2022

Copy link
Copy Markdown
Member

RTM? The macos 1.8 runner is hanging on master too (#730)

@IanButterworth

Copy link
Copy Markdown
Member

I'm going to merge given the discussion above and that tests pass on nightly now

@IanButterworth IanButterworth changed the title remove use of jl_set_value on 1.9 remove use of jl_set_value on 1.9. fix UndefVarError for new nightly error formatting Oct 7, 2022
@IanButterworth
IanButterworth merged commit e8389e8 into master Oct 7, 2022
@IanButterworth
IanButterworth deleted the sb/set-value-nightly branch October 7, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nightly (1.9) tests failing

4 participants