reuse existing typemap search for method overwrite detection #48968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not really make sense to scan the tree twice, when we already will extra this info near completely from the intersection search. The cost was small, but non-negligible.
oscardssmith
pushed a commit
to oscardssmith/julia
that referenced
this pull request
Mar 20, 2023
…ng#48968) It does not really make sense to scan the tree twice, when we already will extra this info near completely from the intersection search. The cost was small, but non-negligible.
KristofferC
pushed a commit
that referenced
this pull request
Mar 24, 2023
It does not really make sense to scan the tree twice, when we already will extra this info near completely from the intersection search. The cost was small, but non-negligible. (cherry picked from commit 38d9d83)
Xnartharax
pushed a commit
to Xnartharax/julia
that referenced
this pull request
Apr 19, 2023
…ng#48968) It does not really make sense to scan the tree twice, when we already will extra this info near completely from the intersection search. The cost was small, but non-negligible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does not really make sense to scan the tree twice, when we already will extra this info near completely from the intersection search. The cost was small, but non-negligible.