Skip to content

Allow tab after key name in TOML.parse #51622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Allow tab after key name in TOML.parse #51622

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af0e189
Allow tab after key name in TOML.parse
jaakkor2 Oct 6, 2023
f04ba42
Merge branch 'master' into tabafterkeyname
oscardssmith Oct 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion base/toml_parser.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ function _parse_key(l::Parser)
else
set_marker!(l)
if accept_batch(l, isvalid_barekey_char)
if !(peek(l) == '.' || peek(l) == ' ' || peek(l) == ']' || peek(l) == '=')
if !(peek(l) == '.' || iswhitespace(peek(l)) || peek(l) == ']' || peek(l) == '=')
c = eat_char(l)
return ParserError(ErrInvalidBareKeyCharacter, c)
end
Expand Down
1 change: 1 addition & 0 deletions stdlib/TOML/test/parse.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ using TOML: ParserError
TOML.parse(IOBuffer(str)) ==
TOML.parse(p, str) == TOML.parse(p, SubString(str)) ==
TOML.parse(p, IOBuffer(str)) == dict
@test TOML.parse("a\t=1") == dict
@test_throws ParserError TOML.parse(invalid_str)
@test_throws ParserError TOML.parse(SubString(invalid_str))
@test_throws ParserError TOML.parse(IOBuffer(invalid_str))
Expand Down