Skip to content

fix 0.7 depwarns #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 23, 2018
Merged

fix 0.7 depwarns #368

merged 5 commits into from
Aug 23, 2018

Conversation

ksmcreynolds
Copy link
Contributor

  • Added undef to array constructors
  • Replaced linspace with range
    • Also updated README example. Not sure if there is a better way to show both 0.6 and 0.7 syntax.
  • Miscellaneous updates to fix depwarns in tests

stevengj
stevengj reviewed Aug 23, 2018
View reviewed changes
test/runtests.jl Outdated
using Test
end

!isdefined(Base, :Base64) && using Base64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's already a VERSION >= v"0.7.0" && using Base64 above. But maybe this can be removed? I don't see any usage of the Base64 module in the test script.

The whole using Test logic can also be replaced with using Compat.Test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, sorry I missed that when merging. Base64 is needed for stringmime.

@stevengj stevengj merged commit 3bd36da into JuliaPy:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ksmcreynolds @stevengj