Skip to content

Conversation

@goerz
Copy link
Member

@goerz goerz commented Mar 23, 2024

Extend get_parameters to arbitrary objects, where parameters are collected into a RecursiveArrayTools.ArrayPartition.

Extend the interface definitions to account for parameters.

ComponentArrays are now the recommended way to define arrays of parameters.

@goerz goerz added the enhancement New feature or request label Mar 23, 2024
@codecov
Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 70.28986% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 88.6%. Comparing base (570ed0a) to head (68025fa).

Files Patch % Lines
src/interfaces/parameterization.jl 64.2% 19 Missing ⚠️
src/interfaces/control.jl 68.6% 17 Missing ⚠️
src/controls.jl 84.0% 4 Missing ⚠️
src/interfaces/amplitude.jl 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master     #73     +/-   ##
========================================
- Coverage    89.6%   88.6%   -1.0%     
========================================
  Files          29      31      +2     
  Lines        1998    2108    +110     
========================================
+ Hits         1790    1867     +77     
- Misses        208     241     +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goerz goerz force-pushed the parameterization branch 2 times, most recently from e203078 to 2a7f6c6 Compare March 23, 2024 22:04
@goerz goerz force-pushed the parameterization branch from 2a7f6c6 to 68025fa Compare March 23, 2024 22:13
@goerz goerz merged commit 68025fa into master Mar 23, 2024
@goerz goerz deleted the parameterization branch March 23, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants