Skip to content

WIP: Option to authorize registrations from a file in the package repo #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nkottary wants to merge 8 commits into
base: master
Choose a base branch
from
Open

WIP: Option to authorize registrations from a file in the package repo #330

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8505b54
WIP: Authorize registrations from a file
nkottary Apr 14, 2021
9942b14
Fix
nkottary Apr 14, 2021
745c0c6
Fix
nkottary Apr 14, 2021
7f70fed
Fix
nkottary Apr 14, 2021
ebc9b2b
Fix
nkottary Apr 14, 2021
14f76e8
Tests and fix
nkottary Apr 15, 2021
302f7c1
Fix
nkottary Apr 15, 2021
e46f2ed
Make auth file name configurable and default to MAINTAINERS
nkottary Apr 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
  • Loading branch information
@nkottary
nkottary committed Apr 14, 2021
commit 9942b144e6dcd158378f70b5e98646b971a90a60
8 changes: 4 additions & 4 deletions src/webui/gitutils.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ is_success(res::AuthSuccess) = true
is_success(res::AuthFailure) = false

const AUTH_REG_FILE = "authorized_registrars.txt"
const AUTH_FILE_NOT_FOUND_ERROR = "`$auth_reg_file` was not found in this repository"
const AUTH_FILE_NOT_FOUND_ERROR = "`$AUTH_REG_FILE` was not found in this repository"
const EMAIL_ID_NOT_PUBLIC = "Please make your email ID public in your GitHub/GitLab settings page"
const USER_NOT_IN_AUTH_LIST_ERROR = "Your email ID is not in the $auth_reg_file of this repository"
const USER_NOT_IN_AUTH_LIST_ERROR = "Your email ID is not in the $AUTH_REG_FILE of this repository"

get_repo_owner_id(repo::GitLab.Project) = repo.owner === nothing ? nothing : repo.owner.username
get_repo_owner_id(repo::GitHub.Repo) = repo.owner === nothing ? nothing : repo.owner.login
Expand Down Expand Up @@ -79,7 +79,7 @@ function isauthorized(u::User{GitHub.User}, repo::GitHub.Repo; ref::AbstractStri

if u.user.login == get_repo_owner_id(repo)
return AuthSuccess()
elseif get(CONFIG, "authtype", "authfile") == "authfile"
elseif get(CONFIG, "authtype", "") == "authfile"
return authorize_user_from_file(forge, u, repo, ref)
elseif repo.organization === nothing
hasauth = @gf @mock is_collaborator(forge, repo.owner.login, repo.name, u.user.login)
Expand Down Expand Up @@ -114,7 +114,7 @@ function isauthorized(u::User{GitLab.User}, repo::GitLab.Project; ref::AbstractS

if u.user.id == get_repo_owner_id(repo)
return AuthSuccess()
elseif get(CONFIG, "authtype", "authfile") == "authfile"
elseif get(CONFIG, "authtype", "") == "authfile"
return authorize_user_from_file(forge, u, repo, ref)
elseif repo.namespace.kind == "user"
hasauth = @gf @mock is_collaborator(forge, repo.owner.username, repo.name, u.user.id)
Expand Down