Skip to content

Backports to v1.10 #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkarrasch merged 9 commits into from
Nov 3, 2024
Merged

Backports to v1.10 #572

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
5d3724a
Inline sparse-times-dense in-place multiplication
dkarrasch Oct 21, 2024
91b0aa5
doc: move solvers doc to `src\solvers.md` (#576)
inkydragon Oct 26, 2024
30fbfc6
Test suite: activate a temp project if we need to install Aqua.jl dur…
DilumAluthge Aug 23, 2023
546be18
Fix docs conflict when building as part of full Julia docs (#430)
ViralBShah Aug 26, 2023
9b8cd14
SparseMatrixCSC constructor with a Tuple of Integers (#523)
jishnub Apr 4, 2024
d2a80a6
Change default QR tolerance to match SPQR (#557)
corbett5 Aug 22, 2024
2d762b3
Manual commit for PR #550 to backport to 1.10 (#577)
ViralBShah Nov 2, 2024
46c8f7e
Merge branch 'release-1.10' into backports-release-1.10
ViralBShah Nov 2, 2024
ec38631
Update ci.yml with more architectures
ViralBShah Nov 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Change default QR tolerance to match SPQR (#557) 
SPQR uses just the double precision epsilon even for Float32.

https://github.com/DrTimothyAldenDavis/SuiteSparse/blob/131471310ef0600b231b8fa7c10a55c3f70afbd9/SPQR/Source/spqr_tol.cpp#L29C6-L30C57
  • Loading branch information
@corbett5 @dkarrasch
corbett5 authored and dkarrasch committed Nov 2, 2024
commit d2a80a6741d721a3dfebf42d5a12531133fb23c7
2 changes: 1 addition & 1 deletion src/solvers/spqr.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ Matrix{T}(Q::QRSparseQ) where {T} = lmul!(Q, Matrix{T}(I, size(Q, 1), min(size(Q

# From SPQR manual p. 6
_default_tol(A::AbstractSparseMatrixCSC) =
20*sum(size(A))*eps(real(eltype(A)))*maximum(norm(view(A, :, i)) for i in 1:size(A, 2))
20*sum(size(A))*eps()*maximum(norm(view(A, :, i)) for i in 1:size(A, 2))

"""
qr(A::SparseMatrixCSC; tol=_default_tol(A), ordering=ORDERING_DEFAULT) -> QRSparse
Expand Down
Loading